| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, thomas(dot)munro(at)enterprisedb(dot)com |
| Subject: | Re: inserts into partitioned table may cause crash |
| Date: | 2018-03-14 08:35:35 |
| Message-ID: | 5AA8DED7.7080207@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2018/03/14 17:25), Etsuro Fujita wrote:
> (2018/03/14 14:54), Amit Langote wrote:
>> Sorry that this may be nitpicking that I should've brought up before, but
>> doesn't ExecPrepareTupleRouting do all the work that's needed for routing
>> a tuple and hence isn't the name a bit misleading? Maybe,
>> ExecPerformTupleRouting?
>
> Actually, I thought of that name as a candidate, too. But I used
> ExecPrepareTupleRouting because I didn't think it would actually perform
> all the work; because it wouldn't do the main work of routing, ie, route
> an inserted tuple to the target partition, which is ExecInsert()'s job.
> I agree that it would do all the work *needed for routing*, though.
One thing to add: having said that, I don't have any strong opinion
about that. How about leaving that for the committer?
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2018-03-14 08:43:59 | Re: inserts into partitioned table may cause crash |
| Previous Message | Aleksander Alekseev | 2018-03-14 08:33:49 | Re: [submit code] I develop a tool for pgsql, how can I submit it |