| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw |
| Date: | 2018-03-05 12:44:37 |
| Message-ID: | 5A9D3BB5.7090801@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Arthur,
(2018/03/03 18:51), Arthur Zakirov wrote:
> On Wed, Feb 28, 2018 at 05:22:42PM +0900, Etsuro Fujita wrote:
>> I rebased the patch over HEAD and revised comments/docs a little bit. Please
>> find attached a new version of the patch.
>
> I've reviewed the patch.
>
> The code is good, clear and it is pretty small. There are documentation
> fixes and additional regression tests.
>
> Unfortunately the patch is outdated and it needs rebasing. Outdated
> files are regression tests files.
>
> After rebasing regression tests they pass.
I rebased the patch over HEAD. Please find attached an updated patch.
Thank you for the review!
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| fix-wco-handling-in-postgres-fdw-v4.patch | text/x-diff | 19.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas 'ads' Scherbaum | 2018-03-05 12:45:23 | Re: [PATCH] Find additional connection service files in pg_service.conf.d directory |
| Previous Message | tushar | 2018-03-05 12:24:18 | Re: Server Crash while executing pg_replication_slot_advance (second time) |