Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw
Date: 2018-03-05 16:57:09
Message-ID: 20180305165708.GA24246@zakirov.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 05, 2018 at 09:44:37PM +0900, Etsuro Fujita wrote:
> I rebased the patch over HEAD. Please find attached an updated patch.

Thank you!

IMHO, it is worth to add more explaining comment into
deparseReturningList, why it is necessary to merge WCO attributes to
RETURNING clause. You already noted it in the thread. I think it could
confuse someone who not very familiar how RETURNING is related with WITH
CHECK OPTION.

--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alex Kane 2018-03-05 17:01:29 Re: All Taxi Services need Index Clustered Heap Append
Previous Message Alvaro Herrera 2018-03-05 16:56:09 Re: [PoC PATCH] Parallel dump to /dev/null