Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Subject: Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly
Date: 2018-03-05 03:21:29
Message-ID: 5A9CB7B9.2040008@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(2018/03/03 5:01), Robert Haas wrote:
> On Fri, Mar 2, 2018 at 1:20 PM, Robert Haas<robertmhaas(at)gmail(dot)com> wrote:
>> On Fri, Mar 2, 2018 at 5:35 AM, Etsuro Fujita
>> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>> Agreed. Better safe than sorry, so I disabled autovacuum for all the tables
>>> created in the postgres_fdw regression test, except the ones with no data
>>> modification created in the sections "test handling of collations" and "test
>>> IMPORT FOREIGN SCHEMA". I'm attaching a patch for that.
>>
>> I have committed this patch. Whee!

Thank you for taking the time on this!

> And that seems to have made things worse. The failures on rhinocerous
> look related:
>
> https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=rhinoceros&br=HEAD

Totally outdated stats used in query planning causes the failures?
ANALYZE right before the plan-changing queries would fix the failures?

> And so does this failure on chub:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=chub&dt=2018-03-02%2016%3A10%3A02

The Git log shows that this was done before the commit.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-03-05 03:28:38 Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index
Previous Message David Gould 2018-03-05 03:19:18 Re: [patch] BUG #15005: ANALYZE can make pg_class.reltuples inaccurate.