Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Subject: Re: postgres_fdw: perform UPDATE/DELETE .. RETURNING on a join directly
Date: 2018-03-02 10:35:29
Message-ID: 5A9928F1.2010206@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

(2018/03/02 3:34), Tom Lane wrote:
> Robert Haas<robertmhaas(at)gmail(dot)com> writes:
>> This is another patch that got past me. Committed now.
>
>> I'd be lying if I said I was filled with confidence that this was
>> going to fix it, but I don't know what to do other than keep tinkering
>> with it until we find something that works.
>
> The buildfarm news on this isn't very good; jaguarundi seems happier,
> but we've seen intermittent failures on four other critters since
> this went in.
>
> The idea of disabling autovacuum seems reasonable to me, but perhaps
> it needs to be done to more of the tables.

Agreed. Better safe than sorry, so I disabled autovacuum for all the
tables created in the postgres_fdw regression test, except the ones with
no data modification created in the sections "test handling of
collations" and "test IMPORT FOREIGN SCHEMA". I'm attaching a patch for
that.

Best regards,
Etsuro Fujita

Attachment Content-Type Size
postgres-fdw-regress-3.patch text/x-diff 8.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-03-02 10:37:26 Re: Kerberos test suite
Previous Message Alexander Korotkov 2018-03-02 10:35:19 Re: zheap: a new storage format for PostgreSQL