Re: non-bulk inserts and tuple routing

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: non-bulk inserts and tuple routing
Date: 2018-01-30 09:22:50
Message-ID: 5A70396A.8090400@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

(2018/01/25 18:52), Amit Langote wrote:
> On 2018/01/25 18:30, Etsuro Fujita wrote:
>> The patches apply cleanly and compile successfully, but make check fails
>> in an assert-enabled build.
>
> Hmm, I can't seem to reproduce the failure with v4 patches I posted
> earlier today.

> Can you please post the errors you're seeing?

A quick debug showed that the failure was due to a segmentation fault
caused by this change to ExecSetupPartitionTupleRouting (in patch
v4-0003-During-tuple-routing-initialize-per-partition-obj):

- bool is_update = false;

+ bool is_update;

I modified that patch to initialize the is_update to false as before.
With the modified version, make check passed successfully.

I'll review the patch in more detail!

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kuzmenkov 2018-01-30 09:31:56 Re: [HACKERS] PoC: full merge join on comparison clause
Previous Message Simon Riggs 2018-01-30 09:16:41 Re: [HACKERS] MERGE SQL Statement for PG11