| From: | Asim Praveen <pasim(at)vmware(dot)com> |
|---|---|
| To: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hao Wu (Pivotal)" <hawu(at)pivotal(dot)io> |
| Subject: | Re: Unnecessary delay in streaming replication due to replay lag |
| Date: | 2020-08-10 08:53:34 |
| Message-ID: | 5A60C516-1A9F-47FA-BDE7-D299A35AB4C1@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 10-Aug-2020, at 12:27 PM, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> wrote:
>
> The patch can be applied cleanly to the current HEAD but I got the
> error on building the code with this patch:
>
> xlog.c: In function 'StartupXLOG':
> xlog.c:7315:6: error: too few arguments to function 'RequestXLogStreaming'
> 7315 | RequestXLogStreaming(ThisTimeLineID,
> | ^~~~~~~~~~~~~~~~~~~~
> In file included from xlog.c:59:
> ../../../../src/include/replication/walreceiver.h:463:13: note: declared here
> 463 | extern void RequestXLogStreaming(TimeLineID tli, XLogRecPtr recptr,
> | ^~~~~~~~~~~~~~~~~~~~
>
> cfbot also complaints this.
>
> Could you please update the patch?
>
Thank you for trying the patch and apologies for the compiler error. I missed adding a hunk earlier, it should be fixed in the version attached here.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Start-WAL-receiver-before-startup-process-replays.patch | application/octet-stream | 17.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surafel Temesgen | 2020-08-10 10:23:44 | Re: FETCH FIRST clause PERCENT option |
| Previous Message | Magnus Hagander | 2020-08-10 08:21:06 | Re: public schema default ACL |