Re: [HACKERS] Custom compression methods

From: David Steele <david(at)pgmasters(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [HACKERS] Custom compression methods
Date: 2021-04-08 15:32:52
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 3/30/21 10:30 AM, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Wed, Mar 24, 2021 at 2:15 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> But let's ignore the case of pg_upgrade and just consider a dump/restore.
>>> I'd still say that unless you give --no-toast-compression then I would
>>> expect the dump/restore to preserve the tables' old compression behavior.
>>> Robert's argument that the pre-v14 database had no particular compression
>>> behavior seems nonsensical to me. We know exactly which compression
>>> behavior it has.
>> I said that it didn't have a state, not that it didn't have a
>> behavior. That's not exactly the same thing. But I don't want to argue
>> about it, either. It's a judgement call what's best here, and I don't
>> pretend to have all the answers. If you're sure you've got it right
>> ... great!
> I've not heard any other comments about this, but I'm pretty sure that
> preserving a table's old toast behavior is in line with what we'd normally
> expect pg_dump to do --- especially in light of the fact that we did not
> provide any --preserve-toast-compression switch to tell it to do so.
> So I'm going to go change it.

It looks like this CF entry should have been marked as committed so I
did that.


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2021-04-08 15:34:25 Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Previous Message Alvaro Herrera 2021-04-08 15:27:57 Re: Autovacuum on partitioned table (autoanalyze)