| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "k(dot)jamison(at)fujitsu(dot)com" <k(dot)jamison(at)fujitsu(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: please update ps display for recovery checkpoint |
| Date: | 2020-12-11 18:54:42 |
| Message-ID: | 59A309AA-87C4-457E-A9D4-922BC5A418BA@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/10/20, 7:54 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> However, I think that it would be better to have all those four code
> paths controlled by a single routine, where we pass down the
> checkpoint flags and fill in the ps string directly depending on what
> the caller wants to do. This way, we will avoid any inconsistent
> updates if this stuff gets extended in the future, and there will be
> all the information at hand to extend the logic. So I have simplified
> your patch as per the attached. Thoughts?
This approach seems reasonable to me. I've attached my take on it.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Add-checkpoint-restartpoint-status-to-ps-display.patch | application/octet-stream | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PegoraroF10 | 2020-12-11 19:06:40 | anonymous block returning like a function |
| Previous Message | Fujii Masao | 2020-12-11 18:48:58 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |