Re: Adding REPACK [concurrently]

From: Antonin Houska <ah(at)cybertec(dot)at>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net>
Subject: Re: Adding REPACK [concurrently]
Date: 2026-06-19 06:48:51
Message-ID: 5998.1781851731@localhost
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This is a diff to remove a comment that was only valid in earlier versions of
the patch - I failed to notice that so far. Another comment in
copy_table_data() explains why rd_toastoid is not set in the CONCURRENTLY
mode:

* This would not work with CONCURRENTLY because we may need to delete
* TOASTed tuples from the new heap. With this hack, we'd delete them
* from the old heap.
*/
NewHeap->rd_toastoid = OldHeap->rd_rel->reltoastrelid;

--
Antonin Houska
Web: https://www.cybertec-postgresql.com

Attachment Content-Type Size
repack_comment.diff text/x-diff 506 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Richard Guo 2026-06-19 06:43:44 Re: Fix HAVING-to-WHERE pushdown with mismatched operator families