| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Alexander Kuzmenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] Incremental sort |
| Date: | 2018-04-07 14:52:44 |
| Message-ID: | 59977d4f-7de3-6bd9-e88d-59e06cd2db1c@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/07/2018 04:37 PM, Teodor Sigaev wrote:
>> by this patch. Revised version is attached.
>
> Fine, patch got several rounds of review in all its parts. Is any
> places which should be improved before commit?
>
I personally feel rather uneasy about committing it, TBH.
While I don't see any obvious issues in the patch at the moment, the
recent changes were rather significant so I might easily miss some
unexpected consequences. (OTOH it's true it was mostly about reduction
of scope, to limit the risks.)
I don't have time to do more review and testing on the latest patch
version, unfortunately, certainly not before the CF end.
So I guess the ultimate review / decision is up to you ...
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2018-04-07 15:09:12 | Re: json(b)_to_tsvector with numeric values |
| Previous Message | Dmitry Dolgov | 2018-04-07 14:46:32 | Re: json(b)_to_tsvector with numeric values |