| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres_fdw : altering foreign table not invalidating prepare statement execution plan. |
| Date: | 2016-11-30 09:05:44 |
| Message-ID: | 594bb349-b99b-f234-72c1-e2bdb57210f1@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016/11/30 17:53, Amit Langote wrote:
> On 2016/11/30 17:25, Etsuro Fujita wrote:
>> Done. I modified the patch so that any inval in pg_foreign_server also
>> blows the whole plan cache.
> I noticed the following addition:
>
> + CacheRegisterSyscacheCallback(FOREIGNDATAWRAPPEROID,
> PlanCacheSysCallback, (Datum) 0);
>
> Is that intentional? I thought you meant only to add for pg_foreign_server.
Yes, that's intentional; we would need that as well, because cached
plans might reference FDW-level options, not only server/table-level
options. I couldn't come up with regression tests for FDW-level options
in postgres_fdw, though.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2016-11-30 10:41:23 | Re: Proposal: scan key push down to heap [WIP] |
| Previous Message | Amit Langote | 2016-11-30 08:53:46 | Re: postgres_fdw : altering foreign table not invalidating prepare statement execution plan. |