From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
---|---|
To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Remove custom redundant full page write description from GIN |
Date: | 2025-09-30 12:59:49 |
Message-ID: | 58DDE1C4-E0FC-4CE8-A385-9A57BC29F362@yandex-team.ru |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 26 Sep 2025, at 16:39, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
>
> WDYT?
>
> <v2-0002-Better-gin-pg_waldump.patch><v2-0004-Remove-locator.patch><v2-0003-fix-oversight-of-631118fe1e8f.patch><v2-0001-Remove-custom-full-page-write-decribption-from-GI.patch><v2-0005-Add-comment-to-ginxlogInsertListPage.patch><v2-0006-Remove-custom-logic-for-ginxlogCreatePostingTree-.patch>
Hi!
I think this thread should stick to patches 1 and 2. Which look good to me, but need few words in commit messages.
Patches 3, 4 and 5 deserve their own thread about GIN code beautification, but may be reviewed here. But perhaps, it's OK for them to live here too. They also look correct to me, but, again, lack appropriate commit messages.
Patch 6 is significant improvement and for sure must be discussed in another thread. The idea seems straightforward to me, but it's WAL logging, there might be some unforeseen consequences of any small change.
Best regards, Andrey Borodin.
From | Date | Subject | |
---|---|---|---|
Next Message | Shinya Kato | 2025-09-30 13:00:13 | Re: remove unnecessary include in src/backend/commands/policy.c |
Previous Message | Hayato Kuroda (Fujitsu) | 2025-09-30 12:51:58 | RE: How can end users know the cause of LR slot sync delays? |