Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DOCS - Clarify the publication 'publish_via_partition_root' default value.
Date: 2025-12-16 08:39:10
Message-ID: 589A5246-7E70-4E2D-BBA0-3DD8B8AB78C5@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Dec 15, 2025, at 08:25, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Fri, Dec 12, 2025 at 12:32 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>>
>>
>>
>>> On Dec 12, 2025, at 07:12, Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
>>>
>>> On Thu, Dec 11, 2025 at 12:22 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>>>>> Why not just say clearly what the default value is?
>>>>>
>>>>> PSA: a patch to do that.
>>>
>>> LGTM. (In fact I've read that paragraph three times and still cannot
>>> get it to stick in my head, despite having done a fair amount of
>>> thinking about publish_via_partition_root, so if you have further
>>> improvement ideas I'm all ears.)
>>>
>
> Yeah, I proposed only a very small patch instead of a rewrite only
> because I thought it would have a better chance of acceptance, not
> because I had any love for the rest of that paragraph.
>
>>
>> My feeling is that the preceding long sentence has described both sides expect explicitly mentioning true and false, which makes the following sentence, no matter the original version and the patched version sounds slightly redundant. So I think maybe we can rework the entire paragraph like:
>>
>> ```
>> This parameter controls how changes to a partitioned table (or any of its partitions) are published. When set to true, changes are published using the identity and schema of the partitioned table. When set to false (the default), changes are published using the identity and schema of the individual partitions
>> where the changes actually occurred. Enabling this option allows the changes to be replicated into a non-partitioned table or into a partitioned table whose
>> partition structure differs from that of the publisher.
>> ```
>>
>
> AFAIK, Chao's improved text is mostly good, except I think there might
> be some nuances when there are multiple levels of partitioning.
>
> For example, maybe you need to make this change?
> BEFORE
> When set to true, changes are published using the identity and schema
> of the partitioned table
> AFTER
> When set to true, changes are published using the identity and schema
> of the root partitioned table
> ~~~

Agreed to add “root”.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-12-16 09:15:01 Re: [BUG] [PATCH] Allow physical replication slots to recover from archive after invalidation
Previous Message John Naylor 2025-12-16 08:28:18 Re: [PATCH] Refactor bytea_sortsupport(), take two