Re: Stability of queryid in minor versions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Stability of queryid in minor versions
Date: 2024-04-15 01:19:34
Message-ID: 588801.1713143974@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Apr 15, 2024 at 11:20:16AM +1200, David Rowley wrote:
>> 1. We cannot change Node enums in minor versions
>> 2. We're *unlikely* to add fields to Node types in minor versions, and
>> if we did we'd likely be leaving them out of the jumble calc, plus it
>> seems highly unlikely any new field we wedged into the padding would
>> relate at all to the parsed query.

> Since 16 these new fields would be added by default unless the node
> attribute query_jumble_ignore is appended to it.

They'd also be written/read by outfuncs/readfuncs, thereby breaking
stored views/rules if the Node is one that can appear in a parsetree.
So the bar to making such a change in a stable branch would be very
high.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2024-04-15 01:20:35 s/shm_mq_iovec/struct iovec/
Previous Message Tom Lane 2024-04-15 01:15:49 Re: Fix out-of-bounds in the function GetCommandTagName