Re: [PATCH] Add result_types column to pg_prepared_statements view

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Add result_types column to pg_prepared_statements view
Date: 2022-07-01 10:28:49
Message-ID: 58307e2c-a26c-d438-27f7-5bef9f693943@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19.05.22 17:34, Dagfinn Ilmari Mannsåker wrote:
> Prompted by a question on IRC, here's a patch to add a result_types
> column to the pg_prepared_statements view, so that one can see the types
> of the columns returned by a prepared statement, not just the parameter
> types.
>
> I'm not quite sure about the column name, suggestions welcome.

I think this patch is sensible.

I see one issue: When you describe a prepared statement via the
protocol, if a result field has a domain as its type, the RowDescription
message sends the underlying base type, not the domain type directly
(see SendRowDescriptionMessage()). But it doesn't do that for the
parameters (see exec_describe_statement_message()). I don't know why
that is; the protocol documentation doesn't mention it. Might be worth
looking into, and checking whether the analogous information contained
in this view should be made consistent.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2022-07-01 10:42:01 Re: making relfilenodes 56 bits
Previous Message Joe Conway 2022-07-01 10:17:32 Re: replacing role-level NOINHERIT with a grant-level option