Re: [PATCH] pgpassfile connection option

From: Julian Markwort <julian(dot)markwort(at)uni-muenster(dot)de>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] pgpassfile connection option
Date: 2016-10-27 01:58:07
Message-ID: 58115F2F.4010608@uni-muenster.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks for your quick response, Fabien
> I think that PGPASSFILE is somehow checked twice
yup, that was unintended redundancy...
> I would suggest that the struct gets the value (from option,
> environment or default) and is always used elsewhere. The
> getPgPassFilename function should disappear and PasswordFromFile
> should be simplified significantly.
I agree, however that's easier said than done because the "default" is
only constant by its definition, not by its location.
There is no "default" location as the home directory depends not only on
the system but also on the user. Afaics we can't entirely get rid of a
function to get the location of the default .pgpass file.

Kind regards,
Julian

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2016-10-27 01:59:57 Re: [RFC] Should we fix postmaster to avoid slow shutdown?
Previous Message Craig Ringer 2016-10-27 01:47:05 Re: 9.6, background worker processes, and PL/Java