| From: | Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, <vik(dot)fearing(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New GUC to sample log queries |
| Date: | 2018-11-26 07:54:56 |
| Message-ID: | 57f6714a-ae2c-8fd3-0776-473a4e765f63@anayrat.info |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/26/18 12:40 AM, Thomas Munro wrote:
> On Wed, Nov 21, 2018 at 9:06 PM Adrien Nayrat
> <adrien(dot)nayrat(at)anayrat(dot)info> wrote:
>> Thanks for your comments. Here is the updated patch. I fixed a warning for
>> missing parentheses in this expression:
>> if ((exceeded && in_sample) || log_duration)
>
> Hi Adrien,
>
> GCC 4.8 says:
>
> guc.c:3328:3: error: initialization makes integer from pointer without
> a cast [-Werror]
> },
> ^
> guc.c:3328:3: error: (near initialization for
> ‘ConfigureNamesReal[19].gen.flags’) [-Werror]
>
Sorry, I missed this warning. There was one extra NULL in guc.c.
Here is a new patch.
Thanks
| Attachment | Content-Type | Size |
|---|---|---|
| sample_rate-6.patch | text/x-patch | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-26 08:03:57 | Re: Add extension options to control TAP and isolation tests |
| Previous Message | Nikolay Shaplov | 2018-11-26 07:50:35 | Re: Add extension options to control TAP and isolation tests |