| From: | Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS |
| Date: | 2018-12-26 05:05:26 |
| Message-ID: | 57f271ca-b943-901e-0f56-0862b787b8b2@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2018/12/26 13:50, Michael Paquier wrote:
> On Tue, Dec 25, 2018 at 02:27:03PM +0900, Michael Paquier wrote:
>> Thanks, I have committed this one after making the logic to ignore
>> column numbers a bit smarter, one problem being that "ALTER INDEX foo
>> ALTER COLUMN" would try to suggest SET STATISTICS directly, which is
>> incorrect. Instead I have tweaked the completion so as COLUMN is
>> added after "ALTER INDEX foo ALTER". This could be completed later
>> with the column numbers, in a way similar to what ALTER TABLE does.
>
> Could you rebase the latest patch please? The latest version sent
> does not apply anymore:
> [1]: https://www.postgresql.org/message-id/bcecaf0e-ab92-8271-6887-da213aea9dac@lab.ntt.co.jp
> --
> Michael
Do you mean my "fix_manual_of_alter_index_v2.patch"?
It is able to patch on f89ae34ab8b4d9e9ce8af6bd889238b0ccff17cb like this:
=====
$ patch -p1 < fix_manual_of_alter_index_v2.patch
patching file doc/src/sgml/ref/alter_index.sgml
=====
Thanks,
Tatsuro Yamada
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-12-26 05:09:28 | Re: plpgsql plugin - stmt_beg/end is not called for top level block of statements |
| Previous Message | Tatsuro Yamada | 2018-12-26 05:05:19 | Re: Tab completion for ALTER INDEX|TABLE ALTER COLUMN SET STATISTICS |