Re: perlcritic

Hi Daniel,

On 3/6/17 12:02 PM, Dagfinn Ilmari Mannsåker wrote:
> ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:
>
>> Hi Peter,
>>
>> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>>
>>> I posted this about 18 months ago but then ran out of steam. [ ] Here
>>> is an updated patch. The testing instructions below still apply.
>>> Especially welcome would be ideas on how to address some of the places
>>> I have marked with ## no critic.
>>
>> Attached is a patch on top of yours that addresses all the ## no critic
>> annotations except RequireFilenameMatchesPackage, which can't be fixed
>> without more drastic reworking of the plperl build process.
>>
>> Tested on perl 5.8.1 and 5.24.0 by configuring with --with-perl and
>> --enable-tap-tests followed by make check-world, and running pgindent
>> --build.
>
> Attached is an updated version of the patch, in which
> src/tools/msvc/gendef.pl actually compiles. If someone on Windows could
> test it, that would be great.

You are signed up to review this patch. Do you know when you'll have a
chance to do that?

Thanks,
--
-David
david(at)pgmasters(dot)net