Re: Minor code improvement to postgresGetForeignPlan

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Minor code improvement to postgresGetForeignPlan
Date: 2017-09-01 09:30:38
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2017/04/07 13:12, Tatsuro Yamada wrote:> The declaration of
postgresGetForeignPlan uses baserel, but
> the actual definition uses foreignrel. It would be better to sync.


> Please find attached a patch.

The patch looks good to me, so I'll mark this as Ready for Committer.

(I'm not sure we should do the same thing to the function declaration in
other places such as fdwapi.h and the documentation for consistency, but
if so, I'd vote for leaving that for another patch.)

Best regards,
Etsuro Fujita

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2017-09-01 10:17:46 Re: Crash on promotion when recovery.conf is renamed
Previous Message Etsuro Fujita 2017-09-01 09:28:17 Re: Update comment in ExecPartitionCheck