From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
---|---|
To: | jian he <jian(dot)universality(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: remove unnecessary include in src/backend/commands/policy.c |
Date: | 2025-09-15 00:18:52 |
Message-ID: | 57D0C286-1BA5-4E40-AF26-A3949D0330BD@gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On Sep 14, 2025, at 14:37, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> hi.
>
> in src/backend/commands/policy.c, i found that
> #include "access/htup.h"
> #include "access/htup_details.h"
> #include "catalog/catalog.h"
> #include "nodes/pg_list.h"
> #include "parser/parse_node.h"
> #include "utils/array.h"
>
> is not necessary "include", so I removed it.
>
> we can also remove
> #include "access/relation.h"
> replace relation_open to table_open, since we already did relkind check in
> RangeVarCallbackForPolicy.
> <v1-0001-remove-unnecessary-include-in-policy.c.patch>
LGTM. I built the patch on MacOS M4, and build passed without warning.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2025-09-15 00:30:56 | Re: Add support for specifying tables in pg_createsubscriber. |
Previous Message | Tom Lane | 2025-09-14 23:42:43 | Re: plan shape work |