Re: Archiver not exiting upon crash

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Archiver not exiting upon crash
Date: 2012-05-23 16:26:31
Message-ID: 5790.1337790391@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On mn, 2012-05-21 at 13:14 -0400, Tom Lane wrote:
>> ... wait, scratch that. AFAICS, that commit was totally useless,
>> because BlockSig should always already contain SIGQUIT.

> No, because PostgresMain() deletes it from BlockSig.

Ah. So potentially we have an issue in all the background processes
that have copied-and-pasted that sigdelset call, which seems to be most
of them.

I'm inclined to think this does need to be fixed. Even if it
accidentally works now, it seems fragile as can be; and certainly
it's underdocumented.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2012-05-23 17:05:17 Re: Readme of Buffer Management seems to have wrong sentence
Previous Message Peter Eisentraut 2012-05-23 16:13:52 Re: Archiver not exiting upon crash