Re: Fwd: automatic disable unicode line style when terminal is not unicode

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fwd: automatic disable unicode line style when terminal is not unicode
Date: 2018-03-04 15:53:53
Message-ID: 5771.1520178833@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> I have to return back to 8bit encoding, and in this old world, the unicode
> borders doesn't work. Sure. It can be simply disabled and forced to ascii.
> What do you think about it?

I don't think we should assume we know what the terminal code will do.
If the line style doesn't actually work, the user will notice and change
the setting quickly enough. If we try to do it for him, we might break
situations that work fine now.

The sort of situation I have in mind is, for instance, working through
an ssh connection. IME it's very often the case that the server side
of the connection doesn't really have an accurate idea of the terminal
capabilities or encoding on the user side. Code that's trying to be
smart just results in less-predictable behavior.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2018-03-04 15:54:07 Re: Parallel Aggregates for string_agg and array_agg
Previous Message Jeff Janes 2018-03-04 15:49:46 Re: [patch] BUG #15005: ANALYZE can make pg_class.reltuples inaccurate.