Re: Where's the docs?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Where's the docs?
Date: 2009-10-28 13:43:48
Message-ID: 5764.1256737428@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On Wed, 2009-10-28 at 00:25 -0400, Tom Lane wrote:
>> Josh Berkus <josh(at)agliodbs(dot)com> writes:
>>> OK, this is the genuine failure; the syntax is missing for column triggers:

>>> CREATE TRIGGER name { BEFORE | AFTER } { event [ OR ... ] }
>>> ON table [ FOR [ EACH ] { ROW | STATEMENT } ]
>>> EXECUTE PROCEDURE function_name ( arguments )

>> It's embedded in "event", which isn't spelled out here.

> I know this is a bit suboptimal, but I couldn't think of a better way
> without cluttering up to many things.

Expanding "event" in-place definitely wouldn't be very readable. The
only alternative that seems sane is to do something like what we do
in SELECT:

CREATE TRIGGER ...

where "event" is:

INSERT | UPDATE [ ( column [,...] ) ] | DELETE | TRUNCATE

I am not convinced that it's worth it, but maybe. Certainly the current
psql "\h CREATE TRIGGER" display is not helpful at reminding you where
to put the column names.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message KaiGai Kohei 2009-10-28 13:50:18 Re: SE-PgSQL developer documentation (Re: Reworks for Access Control facilities (r2363))
Previous Message Alvaro Herrera 2009-10-28 13:27:46 Re: SE-PgSQL developer documentation (Re: Reworks for Access Control facilities (r2363))