Re: BUG #15044: materialized views incompatibility with logical replication in postgres 10

From: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
To: Chad Trabant <chad(at)iris(dot)washington(dot)edu>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Subject: Re: BUG #15044: materialized views incompatibility with logical replication in postgres 10
Date: 2018-02-05 15:33:14
Message-ID: 5754c88e-0ea5-ee34-5b4b-e50a6c66822f@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hi,

On 02/02/18 02:39, Chad Trabant wrote:
> On February 1, 2018 17:16:08 "David G. Johnston"
> <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>>> Bug reference:      15044
>>
>> It seems the work-around is to not use "for all tables" in your
> publication
>> definition.
>
>
> Indeed.  My real world case 700+ tables with semi regular additions and
> two materialized views so ALL TABLES was the right fit.
>
>
>> As described it does seem bugged.  The table matview itself is not being
>> published, as documented, but knowledge of its existence as part of the
>> publication is...
>
>
> Exactly.  The matview does not show up in pg_publication_tables but it's
> registered at some level.
>

Indeed this is a bug. For normal publications we take care of this when
adding the relation to the publication but since ALL TABLES publications
don't check for membership we have to filter this directly in the output
plugin.

The attached patch should fix it (CCing to PeterE as the original
committer).

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Fix-filtering-of-unsupported-relations-in-pgoutput.patch text/x-patch 2.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2018-02-05 20:21:14 BUG #15052: unresponsive client
Previous Message PG Bug reporting form 2018-02-05 12:01:50 BUG #15051: Additional information to bug

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-02-05 17:43:44 Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)
Previous Message Haribabu Kommi 2018-02-05 11:43:38 Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types