| From: | Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Sergei Kornilov <sk(at)zsrv(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Subject: | Re: [HACKERS] REINDEX CONCURRENTLY 2.0 |
| Date: | 2019-01-18 18:58:06 |
| Message-ID: | 57479e55-ce26-5c00-2525-09e267c7224a@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16/01/2019 18:59, Alvaro Herrera wrote:
> On 2019-Jan-16, Michael Paquier wrote:
>
>> Regarding the grammar, we tend for the last couple of years to avoid
>> complicating the main grammar and move on to parenthesized grammars
>> (see VACUUM, ANALYZE, EXPLAIN, etc). So in the same vein I think that
>> it would make sense to only support CONCURRENTLY within parenthesis
>> and just plugin that with the VERBOSE option.
>
> That's my opinion too, but I was outvoted in another subthread -- see
> https://postgr.es/m/20181214144529.wvmjwmy7wxgmgyb3@alvherre.pgsql
> Stephen Frost, Andrew Gierth and Andres Freund all voted to put
> CONCURRENTLY outside the parens. It seems we now have three votes to
> put it *in* the parens (you, Peter Eisentraut, me). I guess more votes
> are needed to settle this issue.
My vote is to have homogeneous syntax for all of this, and so put it in
parentheses, but we should also allow CREATE INDEX and DROP INDEX to use
parentheses for it, too.
I supposed we'll keep what would then be the legacy syntax for a few
decades or more.
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-01-18 19:27:38 | Re: [PATCH] pgbench tap tests fail if the path contains a perl special character |
| Previous Message | Tom Lane | 2019-01-18 18:21:40 | More OpenBSD portability fun: getopt() fails on --option |