| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Allowing printf("%m") only where it actually works |
| Date: | 2018-09-26 22:31:07 |
| Message-ID: | 5742.1538001067@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-09-26 17:41:36 -0400, Tom Lane wrote:
>> Well, if you're unhappy about snprintf.c's performance, you could review
>> https://commitfest.postgresql.org/19/1763/
>> so I can push that. In my tests, that got us down to circa 10% penalty
>> for float conversions.
> Uh, I can do that, but the fact remains that your commit slowed down
> COPY and other conversion intensive workloads by a *significant* amount.
[ shrug... ] There are other cases that got faster (particularly after
the above-mentioned patch). I do not wish to consider floating-point
conversion speed as the sole figure of merit for this change. If we
are to consider only the worst-case, we should be reverting JIT.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-09-26 22:45:47 | Re: Allowing printf("%m") only where it actually works |
| Previous Message | Andres Freund | 2018-09-26 22:18:14 | Re: Performance improvements for src/port/snprintf.c |