Re: pgsql: Fix search_path to a safe value during maintenance operations.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Jeff Davis <jdavis(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix search_path to a safe value during maintenance operations.
Date: 2023-06-10 05:33:31
Message-ID: 573014.1686375211@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> Attached a patch to mark those functions as PARALLEL UNSAFE, which
> fixes the problem.

> Alternatively, I could just take out that line, as those SQL functions
> are not controlled by the MAINTAIN privilege. But for consistency I
> think it's a good idea to leave it in so that index functions are
> called with the right search path for amcheck.

I concur with the upthread objection that it is way too late in
the release cycle to be introducing a breaking change like this.
I request that you revert it.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2023-06-10 15:11:54 pgsql: Revert "Fix search_path to a safe value during maintenance opera
Previous Message Andres Freund 2023-06-10 04:35:38 Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2023-06-10 06:51:34 Re: Views no longer in rangeTabls?
Previous Message Andres Freund 2023-06-10 05:26:46 Re: Cleaning up threading code