Re: pgindent vs. git whitespace check

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent vs. git whitespace check
Date: 2023-02-22 22:03:13
Message-ID: 571da410-bb7c-4037-ee96-18154502f3df@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2023-02-22 We 09:52, Tom Lane wrote:
> pgindent has never been very kind to non-end-of-line comments, and
> I'm not excited about working on making it do so. As a thought
> experiment, what would happen if we reversed course and started
> allowing "//" comments? Naive conversion of this comment could
> break the code altogether. (Plenty of programming languages
> don't even *have* non-end-of-line comments.)
>
>

I suspect not allowing // is at least a minor annoyance to any new
developer we acquire under the age of about 40.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-02-22 22:07:39 Re: refactoring relation extension and BufferAlloc(), faster COPY
Previous Message Tom Lane 2023-02-22 21:38:51 Re: Improving inferred query column names