Skip site navigation (1) Skip section navigation (2)

Re: VS 2015 support in src/tools/msvc

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christian Ullrich <chris(at)chrullrich(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: VS 2015 support in src/tools/msvc
Date: 2016-04-24 15:31:40
Message-ID: 571CE6DC.9010501@dunslane.net (view raw, whole thread or download thread mbox)
Thread:
Lists: pgsql-hackers

On 04/23/2016 11:25 PM, Andrew Dunstan wrote:
>
>
> On 04/23/2016 06:33 PM, Tom Lane wrote:
>> I wrote:
>>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>>> On 04/23/2016 05:30 PM, Christian Ullrich wrote:
>>>>> In this case, I would prefer this:
>>>>>
>>>>> #ifdef WIN32_ONLY_COMPILER
>>>>> -typedef int pid_t;
>>>>> +typedef intptr_t pid_t;
>>>>> #endif
>>>> That's a change that will have a pretty wide effect. Everything up to
>>>> now has been pretty low risk, but this worries me rather more. Maybe
>>>> it's safe, but I'd like to hear others' comments.
>>> Yeah, it makes me a bit nervous too.
>> One other thought: even if this is safe for HEAD, I think we could
>> *not* back-patch it into 9.5, because it would amount to an ABI
>> break on Windows anywhere that pid_t is used in globally visible
>> structs or function signatures.  (Maybe there are no such places,
>> but I doubt it.)  So we'd need to go with the messy-cast solution
>> for 9.5.
>
>
>
> It's not that messy. I'm inclined just to make minimal changed to 
> pg_basebackup.c and be done with it. I don't think a compiler warning 
> is worth doing more for.
>
>


OK, here's my final version of the patch, which I will apply in 24 hours 
or so unless there is an objection.

cheers

andrew


Attachment: VS2015-support.patch
Description: binary/octet-stream (10.1 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2016-04-24 15:36:35
Subject: Re: Updated backup APIs for non-exclusive backups
Previous:From: Tom LaneDate: 2016-04-24 15:11:45
Subject: Re: Proposed change to make cancellations safe

Privacy Policy | About PostgreSQL
Copyright © 1996-2018 The PostgreSQL Global Development Group