Re: VS 2015 support in src/tools/msvc

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: Christian Ullrich <chris(at)chrullrich(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: VS 2015 support in src/tools/msvc
Date: 2016-04-24 08:12:38
Message-ID: 571C7FF6.7010802@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23/04/16 08:08, Christian Ullrich wrote:
> * Christian Ullrich wrote:
>
>> * Andrew Dunstan wrote:
>>
>>> On 04/22/2016 02:46 AM, Michael Paquier wrote:
>>
>>>>> Progress report:
>>>>>
>>>>> 1. My VS 2015 installations (I now have several) all generate
>>>>> solution file
>>>>> with:
>>>>> Microsoft Visual Studio Solution File, Format Version 12.00
>>>>> so I propose to set that as the solution file version.
>>>>
>>>> I am wondering why it happens this way for you..
>>>
>>> It's not just me. See the reply at
>>> <https://social.msdn.microsoft.com/Forums/sqlserver/en-US/ea671596-9e8d-4e80-bb1f-8c9bfb1738dc/2012-and-2015-solutions?forum=vcgeneral>
>>>
>>>
>>> and notice that in both cases the Solution file format is version 12.00.
>>
>> Try as I may, I cannot get my VS 2015 to write a version 14 .sln file.
>> It's always "12.00". If I change it to 14 by hand, it still opens and
>> appears to work fine.
>>
>> I tried to find a real-world version 14 solution to see if I can spot a
>> difference between it and the version 12 files, but there appears to be
>> very little out there, and what there is, looks like it was either
>> autogenerated or edited manually. Examples:
>
> OK, so searching on GitHub yielded a few more results, but I could not
> identify a single one that was clearly not created or edited by anything
> other than Visual Studio itself.
>

I did some checking too, and yes it seems having version 12 .sln is fine
or maybe even desirable. We mainly need to make sure that the tools
version is 14 and platform toolset is v140 for MSVC15.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shay Rojansky 2016-04-24 12:04:32 Proposed change to make cancellations safe
Previous Message Fabien COELHO 2016-04-24 06:17:02 Re: pgsql: doc: Fix typos