| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru> |
| Subject: | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |
| Date: | 2021-01-18 15:57:55 |
| Message-ID: | 5711e3e0-f838-b9a1-f383-ea37c70339dc@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/01/18 22:03, Bharath Rupireddy wrote:
> On Mon, Jan 18, 2021 at 6:17 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>>> +1 to add it after "dropped (Note ........)", how about as follows
>>> with slight changes?
>>>
>>> dropped (Note that server name of an invalid connection can be NULL if
>>> the server is dropped), and then such .....
>>
>> Yes, I like this one. One question is; "should" or "is" is better than
>> "can" in this case because the server name of invalid connection is
>> always NULL when its server is dropped?
>
> I think "dropped (Note that server name of an invalid connection will
> be NULL if the server is dropped), and then such ....."
Sounds good to me. So patch attached.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-doc-Add-note-about-the-server-name-of-postgres_fdw_g.patch | text/plain | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2021-01-18 15:58:04 | Re: recovering from "found xmin ... from before relfrozenxid ..." |
| Previous Message | Zhihong Yu | 2021-01-18 15:57:04 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |