Re: WIP: Covering + unique indexes.

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Subject: Re: WIP: Covering + unique indexes.
Date: 2016-04-07 16:01:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

06.04.2016 23:52, Peter Geoghegan:
> On Wed, Apr 6, 2016 at 1:50 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
>> Personally, I like documenting assertions, and will sometimes write
>> assertions that the compiler could easily optimize away. Maybe going
>> *that* far is more a matter of personal style, but I think an
>> assertion about the new index tuple size being <= the old one is just
>> a good idea. It's not about a problem in your code at all.
> You should make index_truncate_tuple()/index_reform_tuple() promise to
> always do this in its comments/contract with caller as part of this,
> IMV.

Mentioned issues are fixed. Patch is attached.

I'd like to remind you that the commitfest will be closed very-very
soon, so I'd like to get your final resolution about the patch.
Not to have it in the 9.6 release will be very disappointing.

I agree that b-tree is a crucial subsystem. But it seems to me, that we
have lack of improvements in this area
not only because of the algorithm's complexity but also because of lack
of enthusiasts to work on it and struggle through endless discussions.
But it's off-topic here. Attention to these development difficulties
will be one of the messages of my pgcon talk.

You know, we lost a lot of time discussing various b-tree problems.
Besides that, I am sure that the patch is really in a good shape. It
hasn't any open problems to fix.
And possible subtle bugs can be found at the testing stage of the release.

Looking forward to your reply.

Anastasia Lubennikova
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
including_columns_10.0.patch text/x-patch 133.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2016-04-07 16:20:24 Re: WIP: Detecting SSI conflicts before reporting constraint violations
Previous Message Peter Eisentraut 2016-04-07 15:57:30 Re: Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees.