| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATH] Jsonb, insert a new value into an array at arbitrary position |
| Date: | 2016-04-06 04:44:01 |
| Message-ID: | 57049411.8020601@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06/04/16 06:13, Dmitry Dolgov wrote:
>
> On 6 April 2016 at 03:29, Andrew Dunstan <andrew(at)dunslane(dot)net
> <mailto:andrew(at)dunslane(dot)net>> wrote:
>
>
> Yeah, keeping it but rejecting update of an existing key is my
> preference too.
>
> cheers
>
> andrew
>
>
> Yes, it sounds quite reasonable. Here is a new version of patch (it will
> throw
> an error for an existing key). Is it better now?
This seems like reasonable compromise to me. I wonder if the errcode
should be ERRCODE_INVALID_PARAMETER_VALUE but don't feel too strongly
about that.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2016-04-06 05:14:34 | Re: Odd system-column handling in postgres_fdw join pushdown patch |
| Previous Message | Noah Misch | 2016-04-06 04:42:35 | Re: Updated backup APIs for non-exclusive backups |