| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Odd system-column handling in postgres_fdw join pushdown patch |
| Date: | 2016-04-05 06:41:00 |
| Message-ID: | 57035DFC.3050802@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016/03/29 15:37, Etsuro Fujita wrote:
> I added two helper functions: GetFdwScanTupleExtraData and
> FillFdwScanTupleSysAttrs. The FDW author could use the former to get
> info about system attributes other than ctids and oids in fdw_scan_tlist
> during BeginForeignScan, and the latter to set values for these system
> attributes during IterateForeignScan (InvalidTransactionId for
> xmins/xmaxs, InvalidCommandId for cmins/cmaxs, and valid values for
> tableoids). Attached is a proposed patch for that. I also slightly
> simplified the changes to make_tuple_from_result_row and
> conversion_error_callback made by the postgres_fdw join pushdown patch.
> What do you think about that?
I revised comments a little bit. Attached is an updated version of the
patch. I think this issue should be fixed in advance of the PostgreSQL
9.6beta1 release.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| postgres-fdw-join-pushdown-syscol-handling-v3.patch | text/x-patch | 21.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Dunstan | 2016-04-05 06:48:24 | Re: Alter or rename enum value |
| Previous Message | Abhijit Menon-Sen | 2016-04-05 06:35:32 | Re: dealing with extension dependencies that aren't quite 'e' |