| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Optimization for updating foreign tables in Postgres FDW |
| Date: | 2016-04-05 06:22:03 |
| Message-ID: | 5703598B.4020908@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016/04/04 20:35, Michael Paquier wrote:
> On Mon, Apr 4, 2016 at 7:49 PM, Etsuro Fujita
> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Here is a patch to fix this issue. As proposed by Michael, I modified
>> execute_dml_stmt so that it uses PQsendQueryParams, not PQexecParams. Any
>> comments are welcome.
> + * This is based on pqSocketCheck.
> + */
> + bool
> + CheckSocket(PGconn *conn)
> + {
> + int ret;
> +
> + Assert(conn != NULL);
> Instead of copying again pqSocketQuery, which is as well copied in
> libpqwalreceiver.c, wouldn't it be better to use WaitLatchOrSocket
> with the socket returned by PQsocket?
Will check. Thanks for the comment!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abhijit Menon-Sen | 2016-04-05 06:35:32 | Re: dealing with extension dependencies that aren't quite 'e' |
| Previous Message | Peter Geoghegan | 2016-04-05 06:18:28 | Re: Timeline following for logical slots |