| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some ri_triggers.c cleanup |
| Date: | 2019-02-25 08:33:34 |
| Message-ID: | 56d791ef-d2c7-f64e-3c62-8ebf1efc7cc6@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-02-24 00:34, Corey Huinker wrote:
> As I suspected, the code for SET NULL and SET DEFAULT are highly similar
> (see .diff), the major difference being two constants, the order of some
> variable declarations, and the recheck in the set-default case.
>
> The changes were so simple that I felt remiss not adding the patch for
> you (see .patch).
Right, this makes a lot of sense, similar to how ri_restrict() combines
RESTRICT and NO ACTION.
I'll take a closer look at your patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2019-02-25 08:49:51 | RE: Protect syscache from bloating with negative cache entries |
| Previous Message | Peter Eisentraut | 2019-02-25 08:29:36 | Re: unconstify equivalent for volatile |