Re: pgsql: XLogReader general code cleanup

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: XLogReader general code cleanup
Date: 2016-04-02 16:12:02
Message-ID: 56FFEF52.5010908@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 03/30/2016 05:57 PM, Alvaro Herrera wrote:
> XLogReader general code cleanup

This is causing compiler warnings on 32-bit environments(?):

xlogreader.c: In function ‘XLogReadRecord’:
xlogreader.c:334:7: error: format ‘%lu’ expects argument of type ‘long
unsigned int’, but argument 5 has type ‘unsigned int’ [-Werror=format=]
"invalid record length at %X/%X: wanted %lu, got %u",
^
xlogreader.c: In function ‘ValidXLogRecordHeader’:
xlogreader.c:633:7: error: format ‘%lu’ expects argument of type ‘long
unsigned int’, but argument 5 has type ‘unsigned int’ [-Werror=format=]
"invalid record length at %X/%X: wanted %lu, got %u",
^

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-02 17:49:22 pgsql: Suppress compiler warning.
Previous Message Teodor Sigaev 2016-04-02 15:38:20 pgsql: Fix condition in e9e441c9fac6cbc0510cded6abb9d0e6b646ecaf