Correction for replication slot creation error message in 9.6

From: Ian Barwick <ian(at)2ndquadrant(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Correction for replication slot creation error message in 9.6
Date: 2016-03-31 01:15:21
Message-ID: 56FC7A29.5070806@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

Currently pg_create_physical_replication_slot() may refer to
the deprecated wal_level setting "archive":

postgres=# SHOW wal_level ;
wal_level
-----------
minimal
(1 row)

postgres=# SELECT pg_create_physical_replication_slot('some_slot');
ERROR: replication slots can only be used if wal_level is >= archive

Patch changes the error message to:

ERROR: replication slots can only be used if wal_level is "replica" or "logical"

Explicitly naming the valid WAL levels matches the wording in the wal_level
error hint used in a couple of places, i.e.

"wal_level must be set to "replica" or "logical" at server start."

Regards

Ian Barwick

--
Ian Barwick http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
replslot-error-msg.patch text/x-patch 704 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh berkus 2016-03-31 01:23:49 Re: Please correct/improve wiki page about abbreviated keys bug
Previous Message Craig Ringer 2016-03-31 01:14:03 Re: pg_xlogdump fails to handle WAL file with multi-page XLP_FIRST_IS_CONTRECORD data