| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
| Cc: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Speedup twophase transactions |
| Date: | 2016-03-29 15:04:46 |
| Message-ID: | 56FA998E.1090009@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Stas,
On 3/22/16 9:20 AM, Michael Paquier wrote:
> Not taking ProcArrayLock here?
>
> The comment at the top of XlogReadTwoPhaseData is incorrect.
>
> RecoverPreparedFromXLOG and RecoverPreparedFromFiles have a lot of
> code in common, having this duplication is not good, and you could
> simplify your patch.
It looks like you should post a new patch or respond to Michael's
comments. Marked as "waiting on author".
Thanks,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sridhar N Bamandlapally | 2016-03-29 15:09:10 | Re: pg_largeobject |
| Previous Message | David Steele | 2016-03-29 15:01:45 | Re: OOM in libpq and infinite loop with getCopyStart() |