| From: | Marko Tiikkaja <marko(at)joh(dot)to> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Matthias Kurz <m(dot)kurz(at)irregular(dot)at>, Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Alter or rename enum value |
| Date: | 2016-03-27 17:43:27 |
| Message-ID: | 56F81BBF.7010905@joh.to |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2016-03-27 19:30, Dagfinn Ilmari Mannsåker wrote:
> ilmari(at)ilmari(dot)org (Dagfinn Ilmari Mannsåker) writes:
>
>> I was bored and thought "how hard could it be?", and a few hours'
>> hacking later, I have something that seems to work. It doesn't do IF
>> NOT EXISTS yet, and the error messaging could do with some improvement,
>> and there are no docs. The patch is attached, as well as at
>> https://github.com/ilmari/postgres/commit/enum-alter-value
>
> Here's v3 of the patch of the patch, which I consider ready for proper
> review.
A couple of trivial comments below.
+ <term><literal>ALTER VALUE [ IF EXISTST ] TO [ IF NOT EXISTS
]</literal></term>
typo EXISTST
+ If <literal>IF EXISTS</literal> or is <literal>IF NOT
EXISTS</literal>
+ is specified, it is not an error if the type doesn't contain
the old
double is
+ if the old value is not alreeady present or the new value is.
typo alreeady
+ * RenameEnumLabel
+ * Add a new label to the enum set. By default it goes at
copypaste-o?
+ if (!stmt->oldVal) {
not project curly brace style
.m
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= | 2016-03-27 17:58:12 | Re: [PATCH] Alter or rename enum value |
| Previous Message | Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= | 2016-03-27 17:30:11 | [PATCH] Alter or rename enum value |