Re: Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)

From: Chapman Flack <chap(at)anastigmatix(dot)net>
To: Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: PROPOSAL: make PostgreSQL sanitizers-friendly (and prevent information disclosure)
Date: 2016-03-21 14:35:48
Message-ID: 56F006C4.2030409@anastigmatix.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/21/2016 10:21 AM, Aleksander Alekseev wrote:

> Well in this case here is a patch that fixes "use of uninitialized
> value" reports by MemorySanitizer I managed to catch so far.

I'm new here so someone more experienced would have to weigh in,
but I would wonder a couple of things:

a. whether a braced struct assignment is supported in every
C compiler that PostgreSQL still intends to support

b. whether such a struct assignment is guaranteed to initialize
padding spaces as well as declared fields (in all supported
C versions/compilers).

It's possible that memset() would be more convincing.

-Chap

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-03-21 14:39:27 Re: [COMMITTERS] pgsql: Support parallel aggregation.
Previous Message David Fetter 2016-03-21 14:35:21 Re: [COMMITTERS] pgsql: Support parallel aggregation.