Re: [PATCH] Phrase search ported to 9.6

I tried to find some bugs in the code. I can't find them. But it does
not mean that there are not bugs.

Still there are a lack of comments and trailing whitespaces.

On 16.03.2016 19:38, Dmitry Ivanov wrote:
> Hi, Artur
>
> I've made an attempt to fix some of the issues you've listed, although there's
> still much work to be done. I'll add some comments later.
>
>> This function has the duplicated piece from the tsvector_setweight()
>> from tsvector_op.c. You can define new function for it.
>
> I'm not sure it's worth the trouble. IMO these functions are relatively small
> and we won't benefit from extracting the duplicate code.

I think that a separate function would be better. These weights are
occurred in other functions. But I might be wrong and maybe I cavil at
the code too much.

>
>> These functions was removed in 9acb9007de30b3daaa9efc16763c3bc6e3e0a92d.
>> It seems that tsvector_op.c was not synchronized with the master.
>
> Got it, thanks!
>

--
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company