| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reworks of CustomScan serialization/deserialization |
| Date: | 2016-03-17 08:05:41 |
| Message-ID: | 56EA6555.4060408@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 15/03/16 05:03, Kouhei Kaigai wrote:
> Petr,
>
> The attached patch is the revised one that follows the new extensible-
> node routine.
>
> It is almost same the previous version except for:
> - custom-apis.[ch] was renamed to custom-node.[ch]
> - check for the length of custom-scan-method name followed
> the manner of RegisterExtensibleNodeMethods()
>
Hi,
looks good, only nitpick I have is that it probably should be
custom_node.h with underscore given that we use underscore everywhere
(except for libpq and for some reason atomic ops).
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2016-03-17 08:09:53 | Re: [PATH] Jsonb, insert a new value into an array at arbitrary position |
| Previous Message | Petr Jelinek | 2016-03-17 08:01:26 | Re: Relation extension scalability |