Re: [PATCH] Supporting +-Infinity values by to_timestamp(float8)

From: Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
To: David Steele <david(at)pgmasters(dot)net>, Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Supporting +-Infinity values by to_timestamp(float8)
Date: 2016-03-16 10:40:05
Message-ID: 56E93805.1020008@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

15.03.2016 22:28, David Steele:
> On 3/4/16 2:56 PM, Vitaly Burovoy wrote:
>
>> On 3/4/16, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru> wrote:
>>
>>> I think that you should update documentation. At least description of
>>> epoch on this page:
>>> http://www.postgresql.org/docs/devel/static/functions-datetime.html
>> Thank you very much for pointing where it is located (I saw only
>> "to_timestamp(TEXT, TEXT)").
>> I'll think how to update it.
> Vitaly, have you decided how to update this yet?
>
>>> 3. (nitpicking) I don't sure about "4STAMPS" suffix. "4" is nice
>>> abbreviation, but it seems slightly confusing to me.
>> It doesn't matter for me what it is called, it is short enough and
>> reflects a type on which it is applied.
>> What would the best name be for it?
> Anastasia, any suggestions for a better name, or just leave it as is?
>
> I'm not in favor of the "4", either. I think I would prefer
> JULIAN_MAXYEAR_STAMP.
>

This point is related to another patch
https://commitfest.postgresql.org/9/540/.
And added to this patch just for compatibility.
If Tom wouldn't change the name of the macros there, I don't see any
reasons why should we do it in this patch.

--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rahila Syed 2016-03-16 10:44:13 Re: [PROPOSAL] VACUUM Progress Checker.
Previous Message Craig Ringer 2016-03-16 10:04:44 Re: WIP: Failover Slots