From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: syslog configurable line splitting behavior |
Date: | 2016-03-16 09:56:16 |
Message-ID: | 56E92DC0.4080808@proxel.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 03/16/2016 03:50 AM, Peter Eisentraut wrote:
> On 3/8/16 9:12 PM, Andreas Karlsson wrote:
>> I have one nitpick: why is one of the variables "true" while the other
>> is "on" in the example? I think both should be "on".
>>
>> #syslog_sequence_numbers = true
>> #syslog_split_lines = on
>>
>> Another possible improvement would be to change "Split messages sent to
>> syslog." to something more verbose like "Split messages sent to syslog,
>> by lines and to fit in 1024 bytes.".
>
> Updated patches with your suggestions. I also renamed
> syslog_split_lines to syslog_split_messages, which I think is more accurate.
I think the patch looks good now. I will change the status to "Ready for
committer".
Andreas
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2016-03-16 10:04:44 | Re: WIP: Failover Slots |
Previous Message | Constantin S. Pan | 2016-03-16 09:55:39 | Re: [WIP] speeding up GIN build with parallel workers |