Re: Minor bug affecting ON CONFLICT lock wait log messages

From: Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>
To: Peter Geoghegan <pg(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Minor bug affecting ON CONFLICT lock wait log messages
Date: 2016-03-15 12:39:38
Message-ID: 56E8028A.60806@dalibo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15/03/2016 03:30, Peter Geoghegan wrote:
> On Mon, Mar 7, 2016 at 1:46 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
>> Attached patch fixes a bug reported privately by Stephen this morning.
>
> Bump.
>
> I would like to see this in the next point release. It shouldn't be
> hard to review.
>

+ reason_wait = indexInfo->ii_ExclusionOps ?
+ XLTW_RecheckExclusionConstr : XLTW_InsertIndex;

Shouldn't it be set to XLTW_InsertIndexUnique instead?

Otherwise the patch seems ok to me.

> Thanks
>

--
Julien Rouhaud
http://dalibo.com - http://dalibo.org

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2016-03-15 13:04:12 Re: Timeline following for logical slots
Previous Message Anastasia Lubennikova 2016-03-15 10:46:21 Re: Re: [PATCH] Integer overflow in timestamp[tz]_part() and date/time boundaries check