Re: Speed up Clog Access by increasing CLOG buffers

From: David Steele <david(at)pgmasters(dot)net>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Thom Brown <thom(at)linux(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Speed up Clog Access by increasing CLOG buffers
Date: 2016-03-14 18:30:05
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

On 2/26/16 11:37 PM, Amit Kapila wrote:

> On Sat, Feb 27, 2016 at 10:03 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com
> Here, we can see that there is a gain of ~15% to ~38% at higher
> client count.
> The attached document (perf_write_clogcontrollock_data_v6.ods)
> contains data, mainly focussing on single client performance. The
> data is for multiple runs on different machines, so I thought it is
> better to present in form of document rather than dumping everything
> in e-mail. Do let me know if there is any confusion in
> understanding/interpreting the data.
> Forgot to mention that all these tests have been done by
> reverting commit-ac1d794.

This patch no longer applies cleanly:

$ git apply ../other/group_update_clog_v6.patch
error: patch failed: src/backend/storage/lmgr/proc.c:404
error: src/backend/storage/lmgr/proc.c: patch does not apply
error: patch failed: src/include/storage/proc.h:152
error: src/include/storage/proc.h: patch does not apply

It's not clear to me whether Robert has completed a review of this code
or it still needs to be reviewed more comprehensively.

Other than a comment that needs to be fixed it seems that all questions
have been answered by Amit.

Is this "ready for committer" or still in need of further review?


In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-03-14 18:30:21 Re: Obsolete comment in postgres_fdw.c
Previous Message Tom Lane 2016-03-14 18:28:43 Re: [PATCH] Use correct types and limits for PL/Perl SPI query results