| From: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: auto_explain sample rate |
| Date: | 2016-03-12 14:20:20 |
| Message-ID: | 56E425A4.5050305@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/03/2016 17:55, Robert Haas wrote:
> On Fri, Mar 11, 2016 at 11:33 AM, Tomas Vondra
> <tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>> A bit late, but I think we should rename the GUC variable to
>> "sampling_rate" (instead of sample_ratio) as that's what pgbench uses
>> for the same thing. That'd be more consistent.
>
> I like that idea. It seems like slightly better terminology.
>
I like it too. I also just noticed that I duplicated the var type by
mistake in the documentation :/
Attached patch fixes both.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org
| Attachment | Content-Type | Size |
|---|---|---|
| auto_explain_rate.diff | text/plain | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2016-03-12 14:44:20 | Re: Performance improvement for joins where outer side is unique |
| Previous Message | Mithun Cy | 2016-03-12 14:13:39 | Re: Explain [Analyze] produces parallel scan for select Into table statements. |